Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update KMS blueprint #1129

Merged
merged 2 commits into from
Feb 5, 2023
Merged

Update KMS blueprint #1129

merged 2 commits into from
Feb 5, 2023

Conversation

lcaggio
Copy link
Collaborator

@lcaggio lcaggio commented Feb 5, 2023

Update KMS example:

  • rely on Project level P4SA IAM roles
  • support 'project_create'
  • add 'prefix'
  • remove variables not relevant for the blueprint: vpc name, subnet name, ...

@lcaggio lcaggio marked this pull request as ready for review February 5, 2023 07:08
@lcaggio lcaggio requested review from ludoo and juliocc February 5, 2023 07:09
ludoo
ludoo approved these changes Feb 5, 2023
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment on variables, feel free to disagree :)

blueprints/data-solutions/cmek-via-centralized-kms/variables.tf Outdated Show resolved Hide resolved
@lcaggio lcaggio merged commit 884ec71 into master Feb 5, 2023
@lcaggio lcaggio deleted the lcaggio/kms-update branch February 5, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

@juliocc juliocc Awaiting requested review from juliocc

Assignees
No one assigned
Labels
on:blueprints
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lcaggio @ludoo