Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for GKE #1062

Merged
merged 2 commits into from
Dec 21, 2022
Merged

Fixes for GKE #1062

merged 2 commits into from
Dec 21, 2022

Conversation

wiktorn
Copy link
Collaborator

@wiktorn wiktorn commented Dec 21, 2022

  • Fix non-empty plan when spot instances are used
  • Add cluster_id and recommend its use, as this prevents inconsitencies when only cluster is recreated (with no changes on node pool)

* Fix non-empty plan when spot instances are used
* Add cluster_id and recommend its use, as this prevents inconsitencies
  when only cluster is recreated (with no changes on node pool)
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really clean PR, thanks!

@ludoo ludoo marked this pull request as ready for review December 21, 2022 16:08
@wiktorn wiktorn merged commit 7e18f6d into GoogleCloudPlatform:master Dec 21, 2022
@UpperM
Copy link

UpperM commented Dec 28, 2022

Thanks you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants