-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Networking dashboard and discovery tool refactor #1020
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ludo, adding a few suggestions to discuss.
blueprints/cloud-operations/network-dashboard/deploy-cloud-function/README.md
Show resolved
Hide resolved
blueprints/cloud-operations/network-dashboard/deploy-cloud-function/main.tf
Outdated
Show resolved
Hide resolved
blueprints/cloud-operations/network-dashboard/deploy-cloud-function/README.md
Show resolved
Hide resolved
blueprints/cloud-operations/network-dashboard/deploy-cloud-function/variables.tf
Show resolved
Hide resolved
blueprints/cloud-operations/network-dashboard/deploy-cloud-function/README.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Ludo for this amazing contribution and large scale refactoring!
I was able to test it and the code runs about 6 times faster than before your refactoring. Well done!
@juliocc this is now ready for initial review. I will promote from draft after we have checked some of the more intricate logic with @aurelienlegrand .