Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Networking dashboard and discovery tool refactor #1020

Merged
merged 98 commits into from
Dec 18, 2022
Merged

Networking dashboard and discovery tool refactor #1020

merged 98 commits into from
Dec 18, 2022

Conversation

ludoo
Copy link
Collaborator

@ludoo ludoo commented Nov 28, 2022

@juliocc this is now ready for initial review. I will promote from draft after we have checked some of the more intricate logic with @aurelienlegrand .

Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work

@ludoo ludoo marked this pull request as ready for review November 29, 2022 10:11
Copy link
Collaborator

@aurelienlegrand aurelienlegrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ludo, adding a few suggestions to discuss.

Copy link
Collaborator

@aurelienlegrand aurelienlegrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Ludo for this amazing contribution and large scale refactoring!
I was able to test it and the code runs about 6 times faster than before your refactoring. Well done!

@ludoo ludoo merged commit 93361d7 into master Dec 18, 2022
@ludoo ludoo deleted the ludo/net-dash branch December 18, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants