Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a top-level fixture and override it in packages #10

Merged
merged 1 commit into from
Sep 12, 2019
Merged

Conversation

ludoo
Copy link
Collaborator

@ludoo ludoo commented Sep 12, 2019

This PR moves the fixture code used in tests to the top-level, and overrides it in individual packages to provide the per-package path pointing to the tested sample.

@ludoo ludoo requested a review from averbuks September 12, 2019 10:02
Copy link
Member

@averbuks averbuks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@ludoo ludoo merged commit 8643805 into master Sep 12, 2019
@ludoo ludoo deleted the ludo-fixture branch September 12, 2019 11:31
juliodiez added a commit that referenced this pull request Feb 10, 2023
Merge pull request #9 from GoogleCloudPlatform/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants