fix(bigquery-dataset): Set dataset_id with underscores

modules/bigquery-dataset/README.md

@@ -21,7 +21,7 @@ The access variables are split into `access` and `access_identities` variables,
 module "bigquery-dataset" {
   source     = "./fabric/modules/bigquery-dataset"
   project_id = "my-project"
-  id         = "my-dataset"
+  id         = "my_dataset"
   access = {
     reader-group   = { role = "READER", type = "group" }
     owner          = { role = "OWNER", type = "user" }
@@ -46,7 +46,7 @@ Access configuration can also be specified via IAM instead of basic roles via th
 module "bigquery-dataset" {
   source     = "./fabric/modules/bigquery-dataset"
   project_id = "my-project"
-  id         = "my-dataset"
+  id         = "my_dataset"
   iam = {
     "roles/bigquery.dataOwner" = ["user:[email protected]"]
   }
@@ -143,7 +143,7 @@ Authorized views can be specified both using the standard `access` options and t
 module "bigquery-dataset" {
   source     = "./fabric/modules/bigquery-dataset"
   project_id = "my-project"
-  id         = "my-dataset"
+  id         = "my_dataset"
   authorized_views = [
     {
       project_id = "view_project"
@@ -176,7 +176,7 @@ Dataset options are set via the `options` variable. all options must be specifie
 module "bigquery-dataset" {
   source     = "./fabric/modules/bigquery-dataset"
   project_id = "my-project"
-  id         = "my-dataset"
+  id         = "my_dataset"
   options = {
     default_table_expiration_ms     = 3600000
     default_partition_expiration_ms = null
@@ -227,7 +227,7 @@ locals {
 module "bigquery-dataset" {
   source     = "./fabric/modules/bigquery-dataset"
   project_id = "my-project"
-  id         = "my-dataset"
+  id         = "my_dataset"
   tables = {
     table_a = {
       deletion_protection = true

tests/modules/bigquery_dataset/examples/authorized_resources_views.yaml

@@ -14,7 +14,7 @@
 
 values:
   module.bigquery-dataset.google_bigquery_dataset.default:
-    dataset_id: my-dataset
+    dataset_id: my_dataset
     project: my-project
   module.bigquery-dataset.google_bigquery_dataset_access.authorized_views["view_project_view_dataset_view_id_1"]:
     view:

tests/modules/bigquery_dataset/examples/iam.yaml

@@ -14,11 +14,11 @@
 
 values:
   module.bigquery-dataset.google_bigquery_dataset.default:
-    dataset_id: my-dataset
+    dataset_id: my_dataset
     project: my-project
   module.bigquery-dataset.google_bigquery_dataset_iam_binding.bindings["roles/bigquery.dataOwner"]:
     condition: []
-    dataset_id: my-dataset
+    dataset_id: my_dataset
     members:
     - user:[email protected]
     project: my-project

tests/modules/bigquery_dataset/examples/options.yaml

@@ -14,7 +14,7 @@
 
 values:
   module.bigquery-dataset.google_bigquery_dataset.default:
-    dataset_id: my-dataset
+    dataset_id: my_dataset
     default_partition_expiration_ms: null
     default_table_expiration_ms: 3600000
     delete_contents_on_destroy: false

tests/modules/bigquery_dataset/examples/partitioning.yaml

@@ -14,7 +14,7 @@
 
 values:
   module.bigquery-dataset.google_bigquery_dataset.default:
-    dataset_id: my-dataset
+    dataset_id: my_dataset
     location: EU
     project: my-project
   module.bigquery-dataset.google_bigquery_table.default["table_a"]:

tests/modules/bigquery_dataset/examples/simple.yaml

@@ -14,30 +14,30 @@
 
 values:
   module.bigquery-dataset.google_bigquery_dataset.default:
-    dataset_id: my-dataset
+    dataset_id: my_dataset
     description: Terraform managed.
     location: EU
     project: my-project
   module.bigquery-dataset.google_bigquery_dataset_access.group_by_email["reader-group"]:
-    dataset_id: my-dataset
+    dataset_id: my_dataset
     group_by_email: [email protected]
     project: my-project
     role: READER
   module.bigquery-dataset.google_bigquery_dataset_access.special_group["project_owners"]:
-    dataset_id: my-dataset
+    dataset_id: my_dataset
     project: my-project
     role: OWNER
     special_group: projectOwners
   module.bigquery-dataset.google_bigquery_dataset_access.user_by_email["owner"]:
-    dataset_id: my-dataset
+    dataset_id: my_dataset
     project: my-project
     role: OWNER
     user_by_email: [email protected]
   module.bigquery-dataset.google_bigquery_dataset_access.authorized_views["my-project_my-dataset_my-table"]:
-    dataset_id: my-dataset
+    dataset_id: my_dataset
     project: my-project
     view:
-    - dataset_id: my-dataset
+    - dataset_id: my_dataset
       project_id: my-project
       table_id: my-table