Fix data catalog tag module

GoogleCloudPlatform · Feb 17, 2024 · 39b7133 · 39b7133
1 parent 3ffd574
commit 39b7133
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/modules/data-catalog-tag/README.md b/modules/data-catalog-tag/README.md
@@ -17,7 +17,7 @@ module "data-catalog-tag" {
     "landing/countries" = {
       project_id = "project-data-product"
       parent     = "projects/project-data-product/datasets/landing"
-      location   = "europe-west-1"
+      location   = "europe-west1"
       template   = "projects/project-datagov/locations/europe-west1/tagTemplates/demo"
       fields = {
         source = "DB-1"
@@ -37,7 +37,7 @@ module "data-catalog-tag" {
     "landing/countries" = {
       project_id = "project-data-product"
       parent     = "projects/project-data-product/datasets/landing/tables/countries"
-      location   = "europe-west-1"
+      location   = "europe-west1"
       template   = "projects/project-datagov/locations/europe-west1/tagTemplates/demo"
       fields = {
         source = "DB-1 Table-A"
@@ -58,7 +58,7 @@ module "data-catalog-tag" {
       project_id = "project-data-product"
       parent     = "projects/project-data-product/datasets/landing/tables/countries"
       column     = "country"
-      location   = "europe-west-1"
+      location   = "europe-west1"
       template   = "projects/project-datagov/locations/europe-west1/tagTemplates/demo"
       fields = {
         source = "DB-1 Table-A Column-B"
@@ -87,7 +87,7 @@ module "data-catalog-tag" {
       project_id = "project-data-product"
       parent     = "projects/project-data-product/datasets/landing/tables/countries"
       column     = "country"
-      location   = "europe-west-1"
+      location   = "europe-west1"
       template   = "projects/project-datagov/locations/europe-west1/tagTemplates/demo"
       fields = {
         source = "DB-1 Table-A Column-B"
@@ -106,6 +106,7 @@ module "data-catalog-tag" {
 
 project_id: project-data-product
 parent: projects/project-data-product/datasets/exposure
+location: europe-west1
 template: projects/project-datagov/locations/europe-west1/tagTemplates/test
 fields:
   owner_email: [email protected]

diff --git a/modules/data-catalog-tag/main.tf b/modules/data-catalog-tag/main.tf
@@ -25,7 +25,7 @@ locals {
 
 resource "google_data_catalog_tag" "engine" {
   for_each = local.factory_tag_template
-  parent   = "projects/${each.value.project_id}/locations/${each.value.project_id}/entryGroups/@bigquery/entries/${trim(base64encode(each.value.parent), "=")}"
+  parent   = "projects/${each.value.project_id}/locations/${each.value.location}/entryGroups/@bigquery/entries/${trim(base64encode(each.value.parent), "=")}"
   column   = try(each.value.column, null)
   template = each.value.template
   dynamic "fields" {