Skip to content

Commit

Permalink
Enable E2E tests for net-lb-app-ext-regional
Browse files Browse the repository at this point in the history
HTTP to HTTPS needs work, now fails with:
Error: Error creating ForwardingRule: googleapi: Error 400: Invalid value for field 'resource.IPAddress': '34.160.52.156'. Invalid IP address specified., invalid

  with module.ralb-test-0-redirect.google_compute_forwarding_rule.default,
  on fabric/modules/net-lb-app-ext-regional/main.tf line 32, in resource "google_compute_forwarding_rule" "default":
  32: resource "google_compute_forwarding_rule" "default" {
  • Loading branch information
wiktorn committed Jan 6, 2024
1 parent 18fc367 commit 27df921
Showing 1 changed file with 17 additions and 17 deletions.
34 changes: 17 additions & 17 deletions modules/net-lb-app-ext-regional/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ module "glb-0" {
}
}
}
# tftest modules=3 resources=9 fixtures=fixtures/compute-vm-group-bc.tf
# tftest modules=3 resources=9 fixtures=fixtures/compute-vm-group-bc.tf e2e
```

### Minimal HTTPS examples
Expand Down Expand Up @@ -106,7 +106,7 @@ module "ralb-0" {
}
}
}
# tftest modules=3 resources=12 fixtures=fixtures/compute-vm-group-bc.tf
# tftest modules=3 resources=12 fixtures=fixtures/compute-vm-group-bc.tf e2e
```

#### HTTPS backends
Expand Down Expand Up @@ -146,7 +146,7 @@ module "ralb-0" {
}
}
}
# tftest modules=3 resources=12 fixtures=fixtures/ssl-certificate.tf,fixtures/compute-vm-group-bc.tf
# tftest modules=3 resources=12 fixtures=fixtures/ssl-certificate.tf,fixtures/compute-vm-group-bc.tf e2e
```

#### HTTP to HTTPS redirect
Expand Down Expand Up @@ -209,7 +209,7 @@ module "ralb-test-0" {
}
}
# tftest modules=5 resources=16 fixtures=fixtures/ssl-certificate.tf,fixtures/compute-vm-group-bc.tf
# tftest modules=5 resources=16 fixtures=fixtures/ssl-certificate.tf,fixtures/compute-vm-group-bc.tf e2e
```

### Health Checks
Expand Down Expand Up @@ -242,7 +242,7 @@ module "ralb-0" {
}
}
}
# tftest modules=3 resources=9 fixtures=fixtures/compute-vm-group-bc.tf
# tftest modules=3 resources=9 fixtures=fixtures/compute-vm-group-bc.tf e2e
```

To leverage existing health checks without having the module create them, simply pass their self links to backend services and set the `health_check_configs` variable to an empty map:
Expand All @@ -259,7 +259,7 @@ module "ralb-0" {
backends = [{
backend = module.compute-vm-group-b.group.id
}]
health_checks = ["projects/${var.project_id}/global/healthChecks/custom"]
health_checks = ["projects/${var.project_id}/regions/${var.region}/healthChecks/custom"]
}
}
health_check_configs = {}
Expand Down Expand Up @@ -297,7 +297,7 @@ module "ralb-0" {
}
}
}
# tftest modules=3 resources=10 fixtures=fixtures/compute-vm-group-bc.tf
# tftest modules=3 resources=10 fixtures=fixtures/compute-vm-group-bc.tf e2e
```

#### Managed Instance Groups
Expand Down Expand Up @@ -361,7 +361,7 @@ module "ralb-0" {
}
}
}
# tftest modules=3 resources=8
# tftest modules=3 resources=8 e2e
```

#### Zonal NEG creation
Expand Down Expand Up @@ -391,8 +391,8 @@ module "ralb-0" {
neg_configs = {
neg-0 = {
gce = {
network = "projects/myprj-host/global/networks/svpc"
subnetwork = "projects/myprj-host/regions/europe-west8/subnetworks/gce"
network = var.vpc.self_link
subnetwork = var.subnet.self_link
zone = "${var.region}-b"
endpoints = {
e-0 = {
Expand All @@ -405,7 +405,7 @@ module "ralb-0" {
}
}
}
# tftest modules=3 resources=11 fixtures=fixtures/compute-vm-group-bc.tf
# tftest modules=3 resources=11 fixtures=fixtures/compute-vm-group-bc.tf e2e
```

#### Hybrid NEG creation
Expand Down Expand Up @@ -433,7 +433,7 @@ module "ralb-0" {
neg_configs = {
neg-0 = {
hybrid = {
network = "projects/myprj-host/global/networks/svpc"
network = var.vpc.self_link
zone = "${var.region}-b"
endpoints = {
e-0 = {
Expand All @@ -445,7 +445,7 @@ module "ralb-0" {
}
}
}
# tftest modules=1 resources=7
# tftest modules=1 resources=7 e2e
```

#### Private Service Connect NEG creation
Expand Down Expand Up @@ -476,7 +476,7 @@ module "ralb-0" {
}
}
}
# tftest modules=1 resources=5
# tftest modules=1 resources=5 e2e
```

#### Serverless NEG creation
Expand Down Expand Up @@ -511,7 +511,7 @@ module "ralb-0" {
}
}
}
# tftest modules=1 resources=5
# tftest modules=1 resources=5 e2e
```

### URL Map
Expand Down Expand Up @@ -557,7 +557,7 @@ module "ralb-0" {
}
}
# tftest modules=3 resources=10 fixtures=fixtures/compute-vm-group-bc.tf
# tftest modules=3 resources=10 fixtures=fixtures/compute-vm-group-bc.tf e2e
```

### Complex example
Expand Down Expand Up @@ -687,7 +687,7 @@ module "ralb-0" {
}
}
}
# tftest modules=3 resources=18 fixtures=fixtures/compute-vm-group-bc.tf
# tftest modules=3 resources=18 fixtures=fixtures/compute-vm-group-bc.tf e2e
```

<!-- TFDOC OPTS files:1 -->
Expand Down

0 comments on commit 27df921

Please sign in to comment.