Review fixes

tests/fixtures.py

@@ -224,7 +224,7 @@ def plan_validator(module_path, inventory_paths, basedir, tf_var_files=None,
 
 def validate_plan_object(expected_value, plan_value, relative_path, relative_address):
   # dictionaries / objects
-  if isinstance(expected_value, dict):
+  if isinstance(expected_value, dict) and isinstance(plan_value, dict):
     for k in expected_value.keys():
       assert k in plan_value,  \
         f'{relative_path}: {k} is not a valid address in the plan'
@@ -233,12 +233,12 @@ def validate_plan_object(expected_value, plan_value, relative_path, relative_add
       validate_plan_object(v, plan_value[k], relative_path, f'{relative_address}.{k}')
 
   # lists
-  elif isinstance(expected_value, list):
+  elif isinstance(expected_value, list) and isinstance(plan_value, list):
     assert len(plan_value) == len(expected_value), \
       f'{relative_path}: {relative_address} has different length. Got {plan_value}, expected {expected_value}'
 
-    for idx, (exp, actual) in enumerate(zip(expected_value, plan_value)):
-      validate_plan_object(exp, actual, relative_path, f'{relative_address}[{idx}]')
+    for i, (exp, actual) in enumerate(zip(expected_value, plan_value)):
+      validate_plan_object(exp, actual, relative_path, f'{relative_address}[{i}]')
 
   # all other objects
   else: