Merge pull request #827 from GoogleCloudPlatform/lcaggio/artifact-jit

Project module: Add Artifactregistry Service Identity SA creation.
GoogleCloudPlatform · Sep 20, 2022 · 0bdcaf9 · 0bdcaf9
2 parents 2425ca6 + bdb9086
commit 0bdcaf9
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/blueprints/data-solutions/data-platform-foundations/README.md b/blueprints/data-solutions/data-platform-foundations/README.md
@@ -222,7 +222,7 @@ module "data-platform" {
   prefix              = "myprefix"
 }
 
-# tftest modules=42 resources=314
+# tftest modules=42 resources=315
 ```
 
 ## Customizations

diff --git a/modules/project/service-accounts.tf b/modules/project/service-accounts.tf
@@ -67,6 +67,7 @@ locals {
     }
   )
   service_accounts_jit_services = [
+    "artifactregistry.googleapis.com",
     "cloudasset.googleapis.com",
     "gkehub.googleapis.com",
     "pubsub.googleapis.com",

diff --git a/tests/blueprints/data_solutions/data_platform_foundations/test_plan.py b/tests/blueprints/data_solutions/data_platform_foundations/test_plan.py
@@ -24,4 +24,4 @@ def test_resources(e2e_plan_runner):
   "Test that plan works and the numbers of resources is as expected."
   modules, resources = e2e_plan_runner(FIXTURES_DIR)
   assert len(modules) == 41
-  assert len(resources) == 313
+  assert len(resources) == 314
diff --git a/tests/blueprints/gke/binauthz/test_plan.py b/tests/blueprints/gke/binauthz/test_plan.py
@@ -16,4 +16,4 @@ def test_resources(e2e_plan_runner):
   "Test that plan works and the numbers of resources is as expected."
   modules, resources = e2e_plan_runner()
   assert len(modules) == 13
-  assert len(resources) == 42
+  assert len(resources) == 43