This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

feat: improve firebase error handling #53

Merged

mctavish merged 6 commits into GoogleCloudPlatform:main from mctavish:firebase-backend-errors

Aug 8, 2022

Contributor

mctavish commented Aug 5, 2022 •

edited

Loading

Error handling is now in place with retry logic on most failures.

Tests coverage should suffice for current usage.

mctavish added 2 commits

August 3, 2022 14:12


          Add retry for registration

9b26ce3


          More tests and fixes

8b9a6fd

mctavish requested a review from jasonborg

August 5, 2022 16:14

mctavish added 2 commits

August 5, 2022 16:55


          fix indentation

888145a


          bugfix: data lost when retrying snapshot updates

d0b17a6

jasonborg approved these changes

View reviewed changes

src/googleclouddebugger/firebase_client.py Outdated Show resolved Hide resolved

src/googleclouddebugger/firebase_client.py Show resolved Hide resolved

src/googleclouddebugger/firebase_client.py Outdated Show resolved Hide resolved

src/googleclouddebugger/firebase_client.py Show resolved Hide resolved

tests/firebase_client_test.py Show resolved Hide resolved

tests/firebase_client_test.py Outdated Show resolved Hide resolved

tests/firebase_client_test.py Show resolved Hide resolved


          Address PR comments

113bc06

mctavish requested a review from jasonborg

August 8, 2022 14:51


          Add check for snapshot node ref in logpoint test

7efb17e

jasonborg approved these changes

View reviewed changes

mctavish merged commit b2ecae3 into GoogleCloudPlatform:main

mctavish deleted the firebase-backend-errors branch

August 8, 2022 15:40

gcf-merge-on-green bot referenced this pull request in GoogleCloudPlatform/python-docs-samples


          chore(deps): update dependency google-python-cloud-debugger to v3 (#8247

ef517da

)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [google-python-cloud-debugger](https://togithub.com/GoogleCloudPlatform/cloud-debug-python) | `==2.19` -> `==3.0` | [![age](https://badges.renovateapi.com/packages/pypi/google-python-cloud-debugger/3.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/google-python-cloud-debugger/3.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/google-python-cloud-debugger/3.0/compatibility-slim/2.19)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/google-python-cloud-debugger/3.0/confidence-slim/2.19)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>GoogleCloudPlatform/cloud-debug-python</summary>

### [`v3.0`](https://togithub.com/GoogleCloudPlatform/cloud-debug-python/releases/tag/v3.0)

[Compare Source](https://togithub.com/GoogleCloudPlatform/cloud-debug-python/compare/v2.19...v3.0)

#### What's Changed

-   feat: add Firebase RTDB backend by [@&#8203;mctavish](https://togithub.com/mctavish) in [https://github.com/GoogleCloudPlatform/cloud-debug-python/pull/48](https://togithub.com/GoogleCloudPlatform/cloud-debug-python/pull/48)
-   feat: improve firebase error handling by [@&#8203;mctavish](https://togithub.com/mctavish) in [https://github.com/GoogleCloudPlatform/cloud-debug-python/pull/53](https://togithub.com/GoogleCloudPlatform/cloud-debug-python/pull/53)
-   chore: release 3.0 by [@&#8203;mctavish](https://togithub.com/mctavish) in [https://github.com/GoogleCloudPlatform/cloud-debug-python/pull/54](https://togithub.com/GoogleCloudPlatform/cloud-debug-python/pull/54)
-   build: bump to manylinux2014 by [@&#8203;mctavish](https://togithub.com/mctavish) in [https://github.com/GoogleCloudPlatform/cloud-debug-python/pull/55](https://togithub.com/GoogleCloudPlatform/cloud-debug-python/pull/55)

**Full Changelog**: GoogleCloudPlatform/cloud-debug-python@v2.19...v3.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Never, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/GoogleCloudPlatform/python-docs-samples).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNTMuMCIsInVwZGF0ZWRJblZlciI6IjMyLjE1My4wIn0=-->

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet