Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for plugin compatibility #651

Merged
merged 6 commits into from
Apr 25, 2016
Merged

Check for plugin compatibility #651

merged 6 commits into from
Apr 25, 2016

Conversation

etanshaul
Copy link
Contributor

fixes #650

Adds a notification window if plugin versions are not equal:

image

Todo: finalize and externalize wording.

Note: the check is owned by the cloud tools plugin. Once this is pushed out and users update their plugin, any subsequent plugin updates where the versions are mismatched will show this warning.

@patflynn
Copy link
Contributor

Looks good.

Instead of ' check for updates. Or, manage..'

How about "Please click here to ensure you've updated all your plugins."

Also, localization.

@etanshaul
Copy link
Contributor Author

The only issue with your suggested wording (assuming 'click here' links to the platform/plugin update dialog) is that it also includes platform updates. I did not see the ability to only update installed plugins, but I'll check to make sure.

I think its a little restrictive if the user is forced to also update the platform just to get the latest version of the plugins which is why I added that "manage" link originally.

@patflynn
Copy link
Contributor

interesting. So if there's a platform update and plugin updates, the user
can't pick and choose?

On Mon, Apr 25, 2016 at 3:50 PM, Etan Shaul [email protected]
wrote:

The only issue with your suggested wording (assuming 'click here' links to
the platform/plugin update dialog) is that it also includes platform
updates. I did not see the ability to only update installed plugins, but
I'll check to make sure.

I think its a little restrictive if the user is forced to also update the
platform just to get the latest version of the plugins which is why I added
that "manage" link originally.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#651 (comment)

@etanshaul
Copy link
Contributor Author

etanshaul commented Apr 25, 2016

Not from what I've seen.

Here's what the "check" link opens up (which is the same as choosing check for updates from the help menu). It looks like the platform update supersedes any plugin updates:

image

@etanshaul etanshaul force-pushed the plugin-compat-check branch from 76d4ebc to 5f622a7 Compare April 25, 2016 20:10
@etanshaul
Copy link
Contributor Author

Localized strings

@etanshaul
Copy link
Contributor Author

Actually, if you click "ignore this update" in the above screenshot, and there are outdated plugins, then only plugin updates will be shown:

image

So I think your wording suggestion is fine.

@etanshaul
Copy link
Contributor Author

Updated:

image

@patflynn
Copy link
Contributor

🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

user reported error:
3 participants