Fix/55 uncaught exception gcs backup config #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kwadie
commented
Sep 25, 2024
•
kwadie
commented
- When CSV exports are used in fallback and missing the delimiter and header configs the ConfiguratorController throws an exception at deployment type without a meaningful message. This PR logs a meaningful message about the missing fields but still throws an exception intentionally to fail the deployment instead of running with invalid fallback config
- Updated README to include the missing required fields for GCS CSV exports
…oller for fallback parsing errors at deployment time and adding missing GCS SCV fields to README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.