Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set minimum version to 171.0 #451

Merged
merged 3 commits into from
Sep 15, 2017
Merged

set minimum version to 171.0 #451

merged 3 commits into from
Sep 15, 2017

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Sep 13, 2017

@elharo elharo requested a review from chanseokoh September 13, 2017 18:23
loosebazooka
loosebazooka reviewed Sep 14, 2017
View reviewed changes
.travis.yml Outdated
@@ -9,7 +9,7 @@ cache:
install:
# download Cloud SDK
- wget https://dl.google.com/dl/cloudsdk/channels/rapid/downloads/google-cloud-sdk-135.0.0-linux-x86_64.tar.gz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to edit the wget as well.

loosebazooka
loosebazooka suggested changes Sep 14, 2017
View reviewed changes
Copy link
Contributor

@loosebazooka loosebazooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build broken.

@codecov
Copy link

codecov bot commented Sep 15, 2017 •
edited
Loading

Codecov Report

Merging #451 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #451   +/-   ##
=======================================
  Coverage   66.28%   66.28%           
=======================================
  Files          67       67           
  Lines        1815     1815           
  Branches      281      281           
=======================================
  Hits         1203     1203           
  Misses        489      489           
  Partials      123      123
Impacted Files Coverage Δ
...oogle/cloud/tools/appengine/cloudsdk/CloudSdk.java 43.38% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff4e1d8...20668e0. Read the comment docs.

elharo
elharo commented Sep 15, 2017
View reviewed changes
Copy link
Contributor Author

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build fixed

@elharo elharo merged commit d86701f into master Sep 15, 2017
@elharo elharo deleted the sdk branch September 15, 2017 20:53
JoeWang1127 pushed a commit that referenced this pull request Nov 29, 2023
@elharo
set minimum version to 171.0 (#451)
816fe97 
* set minimum version to 171.0

* travis

* 171
JoeWang1127 pushed a commit that referenced this pull request Nov 29, 2023
@TWiStErRob
fix: replace deprecated archivePath with archiveFile in a backwards c…
ffd72d7 
…ompatible way (#451)
@release-please release-please bot mentioned this pull request Dec 13, 2023
Closed
@release-please release-please bot mentioned this pull request Jan 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loosebazooka loosebazooka loosebazooka approved these changes

@chanseokoh chanseokoh Awaiting requested review from chanseokoh

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

set minimum SDK version to 171.0
3 participants
@elharo @loosebazooka @googlebot