Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't propagate InvalidPathException #428

Closed
wants to merge 3 commits into from
Closed

don't propagate InvalidPathException #428

wants to merge 3 commits into from

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Jun 29, 2017

@loosebazooka @lesv Likely not yet a full solution, but this is the first change we need to make for #427

@elharo elharo requested a review from loosebazooka June 29, 2017 21:37
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

Elliotte Harold added 2 commits June 29, 2017 17:44
@elharo
Copy link
Contributor Author

elharo commented Jun 29, 2017

Results :

Tests run: 211, Failures: 0, Errors: 0, Skipped: 1

I'm not sure why the builds are failing.

@elharo
Copy link
Contributor Author

elharo commented Jun 30, 2017

On kokoro I do get an error:

Results :

Tests in error:
testValidateAppEngineJavaComponents(com.google.cloud.tools.appengine.cloudsdk.CloudSdkTest): Validation Error: Java App Engine components not installed. Fix by running 'gcloud components install app-engine-java' on command-line.

Tests run: 211, Failures: 0, Errors: 1, Skipped: 1

@elharo elharo closed this Jun 30, 2017
@elharo elharo deleted the i427 branch June 30, 2017 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants