Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for java8 in standard staging. #160

Merged
merged 2 commits into from
Jul 11, 2016
Merged

Add support for java8 in standard staging. #160

merged 2 commits into from
Jul 11, 2016

Conversation

loosebazooka
Copy link
Contributor

@meltsufin
Copy link
Member

useRuntimeJava seems a little confusing. Maybe we should just allow the clients to set javaVersion, and the library will figure out what to do with that.

@meltsufin
Copy link
Member

@loosebazooka changed configuration to allow specifying any runtime instead of just boolean for java.

@loosebazooka
Copy link
Contributor Author

🏃

@meltsufin meltsufin merged commit bc3eb94 into master Jul 11, 2016
@meltsufin meltsufin deleted the java8stage branch July 11, 2016 20:55
@meltsufin meltsufin mentioned this pull request Jul 11, 2016
Closed
JoeWang1127 pushed a commit that referenced this pull request Nov 29, 2023
@loosebazooka @meltsufin
Add support for java8 in standard staging. (#160)
cc9e793 
* allow passing runtime = 'java' to bypass the AppCfg restriction to Java 7
JoeWang1127 pushed a commit that referenced this pull request Nov 29, 2023
@akerekes
Update code to use latest plugins-core version (#160)
17a333c 
* WIP - Fixes #158 - dev appserver 1 stuff

* javadoc and simpler code whether checking <services> parameter has been configured by the user

* remove default value from appYamls, revert file->path change

* unit tests for RunMojo

* update appengine-plugins-core dependency to 0.3.0

* try to fix kokoro test

* use custom ports to test run in integration test to avoid port clash on Kokoro

* fix async run test as well for Kokoro
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loosebazooka @meltsufin @googlebot