Fixes #149 - PathResolver should implement an interface to enable mocking #150
Conversation
|
I'm still not convinced this is the right approach. Let's talk on Monday. |
|
|
||
| import java.nio.file.Path; | ||
|
|
||
| public interface IPathResolver { |
There was a problem hiding this comment.
I would rename to plain PathResolver
|
@meltsufin yes, we're still interested in this, but not sure whether this approach is the best. If we'll have an interface, the singleton constraint will be much more difficult to maintain, so we could just change it to a regular class (and not make it a singleton). |
|
I don't think it needs to be a singleton at the API level. This class doesn't have any state. So, it can either be a static utility method, or an interface and a default implementation. I prefer the latter, but making it a static method would not make it worse than it is now. |
…esolver, convert DefaultPathResolver form enum to class
|
@elharo @meltsufin PTAL |
|
I'm not sure why we need the interface here. Just rename DefaultPathResolver to PathResolver, and we're good. It's no longer an unmockable singleton, which was the concern. |
|
LGTM |
|
👍 |
No description provided.