-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FR: when running locally, it would be nice if there is a way to pass custom credentials and project ID to dev appserver #439
Comments
Btw, it used to be in appengine-web.xml :-)
Not sure if the devserver has an extra param now...
…On Thu, Aug 3, 2017 at 4:08 PM, Les Vogel ***@***.***> wrote:
There is apparently a way to pass app-id when you start up the GAE Java
runtime locally. At the very least, it would be good (helpful to Veneer) if:
com.google.appengine.application.id System.property() were set.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#439>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAE4zRtvu_4xdfY5qIOYgCe6mNjIxiYgks5sUlLygaJpZM4OtGFY>
.
|
For gcloud on a Mac and Linux it can be found by:
|
This might work for the command-line build tools, but this doesn't make much sense to IDEs. I wonder what should be done for the IDE story? For IDEs, this can even be dangerous if the gcloud default project ID is silently picked up and actually contacted when running the dev server locally. (If the project is not ever to be contacted/scanned, there is no need for the dev server to know it, so I assume the project is actually contacted.) IDEs don't and shouldn't depend on the gcloud config state. Even if it were OK for the IDEs to use the gcloud default project ID, then IDEs would need to have a way to pass to the dev appserver a login credential that has an access permission to the project. (Again, IDEs don't depend on the gcloud login state and rather have their own login system.) I don't believe there is a way to pass a login credential currently. Then, IDEs would need to ask users to
to run a simple HelloWorld app locally. |
At some point, the IDE's are going to need to do the equivalent of |
So, this is because of the ADC for Veneer? I see. Then, I think the right UX in the context of IDE is to allow users to optionally set an IDE login credential and a GCP project ID (through a friendly UI) when running applications or the dev server. If users want to set the login and the project ID for whatever reasons, they could do so, but these values must certainly be optional, to reduce friction to run apps such as a simple HelloWorld app where every operation is absolutely local. For using IDE login credentials as ADC, I know this can be done through an env variable |
BTW, I think |
I just figured this was a cross project issue so I posted it here. I don't think requiring users to setup ADC G_A_C envVar is the best idea. @patflynn FYI |
Of course, users shouldn't set up the env var themselves. IDEs will provide a UI to select a logged-in account (and enter a GCP project ID) and set up the env var under the hood when running dev servers (in addition to setting up the system property for the project ID). |
There are discussions in the Cloud SDK Downloader design doc (written by @loosebazooka) suggesting that our build tools move away from using any of the gcloud config values (including project, user, or whatever). This will make this FR obsolete. |
This is for the runtime environment locally, these could easily be sent from other sources, or we could document the requirement to set the envVar's - which I'm ok with. |
After all, it looks like setting the system property
|
Said too early. I was told that |
Updated the title, as the system property |
FTR, credentials can be passed with |
Hi, Any update on this topic? I've update to AppEngine Maven Plugin (Cloud SDK based) and now I don't have a way to get the project ID in DevServer. Thanks in advance! |
@gartediego have you tried setting |
Thanks for your response @chanseokoh, but it's not working. Regards, |
…age (#439) * Migrate to GitHub Actions and set up code coverage * fetch-depth: 2
There is apparently a way to pass app-id when you start up the GAE Java runtime locally. At the very least, it would be good (helpful to Veneer) if:
UPDATED by @chanseokoh: this property won't work.com.google.appengine.application.id
System.property() were set.The text was updated successfully, but these errors were encountered: