-
Notifications
You must be signed in to change notification settings - Fork 34
[WIP] Add support for logging based on google-cloud-logging #347
base: async-support
Are you sure you want to change the base?
Conversation
appengine-managed-runtime/pom.xml
Outdated
@@ -31,6 +31,7 @@ | |||
<properties> | |||
<maven.build.timestamp.format>yyyyMMddHHmm</maven.build.timestamp.format> | |||
<appengine.api.version>1.9.40</appengine.api.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably no longer used, but if it is, it should be at least 1.9.48 if not .49
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, thanks!
appengine-managed-runtime/pom.xml
Outdated
@@ -31,6 +31,7 @@ | |||
<properties> | |||
<maven.build.timestamp.format>yyyyMMddHHmm</maven.build.timestamp.format> | |||
<appengine.api.version>1.9.40</appengine.api.version> | |||
<gcloud.api.version>0.8.2-beta-SNAPSHOT</gcloud.api.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you using the -SNAPSHOT ??
You do need to initialize Cloud Logging and turn on the JUL hook to use it. -- I don't see that here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like Greg mentioned, we don't have a non-snapshot release of it yet.
@meltsufin I'm not going to have a chance to run this myself for a few hours. But I'm guessing the problem is that this compat runs with the working directory at $JETTY_BASE rather than in the webapp itself. So your relative path to @lesv the SNAPSHOT is used because the |
@gregw It looks like |
@meltsufin perhaps we need a PR on google-cloud-logging that will print any exceptions to stderr so we one can better debug logging problems in init? |
@gregw Yes, that's a good idea. I also think we need to pull the zone stuff into this PR for now because it sounds like they won't be able to merge that PR and release in a while. |
I'm trying to port over the new logging mechanism to the compat runtime to be used with a custom
logging.properties
file, but not having much luck.In my test app, I have this in
webapp\WEB-INF\logging.properties
:and
appengine-web.xml
has this:@gregw This configuration doesn't seem to be working. I only see logs in the
app
stream and no sign ofgae_app.log
in the Stackdriver Logging UI. Any thoughts?