Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changes to improve debugging for JavaRuntimeViaHttpBase #81

Merged
merged 2 commits into from
Nov 28, 2023
Merged

changes to improve debugging for JavaRuntimeViaHttpBase #81

merged 2 commits into from
Nov 28, 2023

Conversation

lachlan-roberts
Copy link
Collaborator

  • wait for port to be open after starting jetty in separate process instead of an arbitrary Thread.sleep.
  • Use the appengine.debug.port system property to set the debug port for the new process.
  • Some other minor cleanups.

@copybara-service copybara-service bot merged commit 951deeb into main Nov 28, 2023
7 checks passed
@lachlan-roberts lachlan-roberts deleted the debugging-fixes branch September 17, 2024 05:55
srinjoyray pushed a commit that referenced this pull request Nov 12, 2024
@gae-java-bot
Merge pull request #81 from GoogleCloudPlatform:debugging-fixes
1c0c733 
PiperOrigin-RevId: 585837391
Change-Id: I2903ace860f96ba603623de186468e84e582b8f7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olamy olamy Awaiting requested review from olamy

@ludoch ludoch Awaiting requested review from ludoch

Assignees
No one assigned
Labels
ready to pull
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lachlan-roberts @ludoch