Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure flushOnResponseCommit is true for session caches #267

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

lachlan-roberts
Copy link
Collaborator

Ensure that the FlushOnResponseCommit setting is set to true for the GAE SessionCaches.
This configuration was suggested by @janbartel.

If true, a dirty session will be written to the SessionDataStore just before a response is returned to the client. This ensures that subsequent requests to either the same node or a different node see the changed session data.

@copybara-service copybara-service bot merged commit 791338b into main Sep 4, 2024
9 checks passed
@copybara-service copybara-service bot deleted the SessionCacheConfiguration branch September 4, 2024 13:16
@ludoch
Copy link
Collaborator

ludoch commented Sep 6, 2024

I redeployed the QA probers for all runtimes, and it seems OK now.
Still not 100% sure this is it because it used to work before, but QA is green with this and the sessions test.
Thanks!

srinjoyray pushed a commit that referenced this pull request Nov 12, 2024
…ation

PiperOrigin-RevId: 670944612
Change-Id: I159cda26f47419b3d941c1817f32e3cab5d7a7f3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants