Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AppEngineAuthenticator does need to extend LoginAuthenticator for EE10 #247

Merged
merged 2 commits into from
Jul 12, 2024
Merged

AppEngineAuthenticator does need to extend LoginAuthenticator for EE10 #247

merged 2 commits into from
Jul 12, 2024

Conversation

lachlan-roberts
Copy link
Collaborator

There is no reason for the EE10 AppEngineAuthenticator to extend LoginAuthenticator, so instead it should implement Authenticator directly.

@lachlan-roberts lachlan-roberts requested a review from ludoch July 11, 2024 06:27
@copybara-service copybara-service bot merged commit da2bf69 into main Jul 12, 2024
8 of 9 checks passed
@copybara-service copybara-service bot deleted the AuthenticationSessions branch July 12, 2024 04:20
@lachlan-roberts lachlan-roberts mentioned this pull request Aug 5, 2024
Closed
srinjoyray pushed a commit that referenced this pull request Nov 12, 2024
@gae-java-bot
Merge pull request #247 from GoogleCloudPlatform:AuthenticationSessions
9a76a19 
PiperOrigin-RevId: 651633992
Change-Id: I8566531e14d1776e938c9297000a66deb789949d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoch ludoch ludoch approved these changes

Assignees
No one assigned
Labels
ready to pull
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lachlan-roberts @ludoch