Fixes for EE10AppEngineAuthentication #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
lachlan-roberts
changed the title
ludoch
approved these changes
Jul 9, 2024
srinjoyray
pushed a commit
that referenced
this pull request
Nov 12, 2024
…ownRoles PiperOrigin-RevId: 650514293 Change-Id: I2d7bcea4fb39b8ee6aad674de95092af0ce01c81
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
DevAppEngineWebAppContextcallssecurityHandler.setConstraintMappings(mappings)to disableConstraint.Transport.SECUREin security constraints, it adjusts the known roles in theSecurityHandler. This PR ensures the known roles are preserved.Also fixed some issues with the EE10AppEngineAuthentication. For example it was not completing the callback on redirect.