Add tests for ServletContextListener for jetty94, EE8 and EE10 #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <[email protected]>
…ontextListenerTest Signed-off-by: Lachlan Roberts <[email protected]>
|
These tests will currently fail because the fix is introduced in PR #188. |
ludoch
approved these changes
May 14, 2024
Signed-off-by: Lachlan Roberts <[email protected]>
ludoch
approved these changes
May 14, 2024
ludoch
approved these changes
May 14, 2024
ludoch
approved these changes
May 14, 2024
ludoch
approved these changes
May 14, 2024
ludoch
approved these changes
May 14, 2024
srinjoyray
pushed a commit
that referenced
this pull request
Nov 12, 2024
…er-tests PiperOrigin-RevId: 633632526 Change-Id: Icc559359d1e644ee40555e7fa2654dd154142d73
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add tests for ServletContextListener to prevent any further regressions
The test is parameterized over jetty94, EE8 and EE10 and also the new mode to bypass RPC