fix infinite redirect bug in ResourceFileServlet for EE10 #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <[email protected]>
ludoch
approved these changes
Apr 29, 2024
ludoch
pushed a commit
that referenced
this pull request
Apr 29, 2024
-- 1d008e7 by Lachlan Roberts <[email protected]>: fix infinite redirect bug in ResourceFileServlet for EE10 Signed-off-by: Lachlan Roberts <[email protected]> COPYBARA_INTEGRATE_REVIEW=#113 from GoogleCloudPlatform:ResourceFileServlet-infiniteRedirect 1d008e7 PiperOrigin-RevId: 628941837 Change-Id: I7d82a749da482858210818a584b69b577b38ed57
srinjoyray
pushed a commit
that referenced
this pull request
Nov 12, 2024
-- 1d008e7 by Lachlan Roberts <[email protected]>: fix infinite redirect bug in ResourceFileServlet for EE10 Signed-off-by: Lachlan Roberts <[email protected]> COPYBARA_INTEGRATE_REVIEW=#113 from GoogleCloudPlatform:ResourceFileServlet-infiniteRedirect 1d008e7 PiperOrigin-RevId: 628941837 Change-Id: I7d82a749da482858210818a584b69b577b38ed57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getMappedServlet("/")was finding the context root mapping instead of the default mapping, this could cause an infinite redirect bug.This PR changes this to use
getServletMapping("/")which tests by pathSpec.