This repository has been archived by the owner on Jun 14, 2024. It is now read-only.
chore: update GRADLE_MIN_VERSION in check and test suite to 4.0 #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegomarquezp
approved these changes
Jul 4, 2023
diegomarquezp
approved these changes
Jul 4, 2023
diegomarquezp
suggested changes
Jul 4, 2023
There was a problem hiding this comment.
Windows CI fails with
ERROR: JAVA_HOME is set to an invalid directory: c:\program files\java\jdk1.8.0_152
Please set the JAVA_HOME variable in your environment to match the
location of your Java installation.
No changes in continuous.bat so far.
Kokoro .cfg files haven't been altered either
|
@diegomarquezp Ah, this issue looks like it might be similar to GoogleCloudPlatform/appengine-plugins#912, let me check in a separate PR (EDIT: #459). |
diegomarquezp
approved these changes
Jul 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
GRADLE_MIN_VERSIONused in checks and test suite to 4.0 to align with documentation in README, along with refactoring suggested in #450 (comment).Resolves #450.