Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

Refactor Maven publication: maven -> maven-publish #398

Closed
wants to merge 10 commits into from
+218 −188
Closed

Refactor Maven publication: maven -> maven-publish #398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
899ce00
Add .editorconfig for automatic editor configuration
vlsi Feb 14, 2021
2e8cfb7
style: build.gradle.kts, fix indentation in build.gradle.kts (Google …
vlsi Sep 7, 2022
fc9c9bb
style: build.gradle.kts, move license header to the top of build.grad…
vlsi Apr 2, 2023
79d34f2
style: build.gradle.kts, remove excessive "configure {" calls
vlsi Apr 2, 2023
484d926
style: build.gradle.kts, use editor-friendly <editor-fold> separator …
vlsi Apr 2, 2023
d0de6c9
use lazy API for configuring Checkstyle task: avoid reading google_ch…
vlsi Apr 2, 2023
adf9ecb
style: build.gradle.kts, use variable references for integTestSourceS…
vlsi Apr 2, 2023
f3d606f
Refactor Maven publication: maven -> maven-publish
vlsi Apr 2, 2023
0ab2c7e
chore: simplify options.compilerArgs configuration
vlsi Apr 2, 2023
45cd6d2
chore: use compileOnly for gradleApi
vlsi Apr 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions .editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
root = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't typically check editorconfig into Java projects.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why's that?
editorconfig is helpful (e.g. "trim whitespace", "configure indentation", and even "import order for java"), so why do you suggest removing it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't the hill I am planning to die on, but the answer is because nobody on the team that maintains this project uses editorconfig plugins.

Copy link
Contributor

@TWiStErRob TWiStErRob Jan 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you use IntelliJ IDEA to edit the code, @elefeint? If so, you are using EditorConfig plugins: https://www.jetbrains.com/help/idea/editorconfig.html

Note that checking in this file would help external contributors (e.g. I edited the code, pressed autoformat shortcut, and EVERYTHING changed). We could have 0-configuration experience (import and it "just works"). Discovering and running gradlew googleJavaFormat is just not the norm in the world of IDEs outside of Google.


[*]
trim_trailing_whitespace = true
insert_final_newline = true
charset = utf-8
indent_style = space

[{*.sh,gradlew}]
end_of_line = lf

[{*.bat,*.cmd}]
end_of_line = crlf

[{*.kts,*.kt}]
max_line_length = 100
# Google Kotlin code style uses 2 spaces for indentation
# See https://github.com/GoogleCloudPlatform/app-gradle-plugin/pull/398/files#r984944216
indent_size = 2
Loading