Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add connectivity sample for Python #201

Merged
merged 22 commits into from
Dec 13, 2022
Merged

chore: add connectivity sample for Python #201

merged 22 commits into from
Dec 13, 2022

Conversation

shubha-rajan
Copy link
Contributor

No description provided.

@shubha-rajan
Copy link
Contributor Author

shubha-rajan commented Dec 9, 2022

Current issue with Python GH actions check: our tests run on a custom flex runner which runs Debian, but the setup-python action only works on Ubuntu (see: actions/setup-python#401)

Edit: Skipping the Setup Python step since we're using a python docker image for the custom runner

@shubha-rajan shubha-rajan marked this pull request as ready for review December 12, 2022 23:06
@shubha-rajan shubha-rajan requested review from a team and jackwotherspoon December 12, 2022 23:06
Copy link
Contributor

@jackwotherspoon jackwotherspoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly minor nits, looks great!

.github/workflows/sample-tests.yaml Outdated Show resolved Hide resolved
examples/python/Dockerfile Outdated Show resolved Hide resolved
examples/python/README.md Show resolved Hide resolved
examples/python/README.md Show resolved Hide resolved
examples/python/README.md Outdated Show resolved Hide resolved
examples/python/main.py Outdated Show resolved Hide resolved
examples/python/templates/index.html Outdated Show resolved Hide resolved
@shubha-rajan shubha-rajan merged commit e1a40e7 into main Dec 13, 2022
@shubha-rajan shubha-rajan deleted the python-sample branch December 13, 2022 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants