Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pirillo/litgpt nvtx #354

Merged
merged 8 commits into from
Feb 21, 2024
Merged

Pirillo/litgpt nvtx #354

merged 8 commits into from
Feb 21, 2024

Conversation

Chris113113
Copy link
Collaborator

No description provided.

@Chris113113 Chris113113 marked this pull request as ready for review January 10, 2024 18:03
@Chris113113 Chris113113 requested a review from gkroiz January 10, 2024 18:03
@Chris113113 Chris113113 changed the base branch from main to develop January 10, 2024 18:08
Copy link
Collaborator

@gkroiz gkroiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review, was OOO. @Chris113113 just want to double check, has this been tested?

@tejasnagendra
Copy link
Collaborator

I was able to run and confirm that we can get nsight profiles. If possible can we also enable collecting GPU statistics (https://docs.nvidia.com/nsight-systems/UserGuide/index.html#gpu-metrics)?

Copy link
Collaborator

@gkroiz gkroiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Chris113113 Chris113113 merged commit 20673da into develop Feb 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants