Aws i3 support #1308
Merged
Aws i3 support #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehankland
reviewed
Mar 7, 2017
| @@ -294,6 +296,10 @@ def __init__(self, vm_spec): | |||
| raise ValueError( | |||
| 'In order to use dedicated hosts, you must specify an availability ' | |||
| 'zone, not a region ("zone" was %s).' % self.zone) | |||
| if self.machine_type[:2].lower() == 'i3' and not FLAGS['image'].present: | |||
There was a problem hiding this comment.
the image can be specified through configs too
| @@ -136,7 +137,8 @@ def GetBlockDeviceMap(machine_type, root_volume_size_gb=None, | |||
| root_block_device['Ebs'].pop('Encrypted') | |||
| mappings.append(root_block_device) | |||
|
|
|||
| if machine_type in NUM_LOCAL_VOLUMES: | |||
| if (machine_type in NUM_LOCAL_VOLUMES and | |||
| not aws_disk.LocalDriveIsNvme(machine_type)): | |||
There was a problem hiding this comment.
Are you sure you don't ever need to supply a mapping for i3s?
There was a problem hiding this comment.
|
@ehankland PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.