Simple memcached ycsb benchmark based on aerospike ycsb benchmark #1199
Conversation
|
|
||
|
|
||
| def YumInstall(vm): | ||
| """Installs the curl package on the VM.""" |
|
|
||
|
|
||
| def AptInstall(vm): | ||
| """Installs the curl package on the VM.""" |
|
|
||
| MEMCACHED_PORT = 11211 | ||
|
|
||
| flags.DEFINE_integer('memcached_size', 64, |
There was a problem hiding this comment.
include unit in flag names
|
|
||
| FLAGS = flags.FLAGS | ||
|
|
||
| LATEST_URL = 'http://memcached.org/latest' |
There was a problem hiding this comment.
Suggest using fixed version (at least fixed major version)
|
|
||
|
|
||
| def YumInstall(vm): | ||
| """Installs the memtier package on the VM.""" |
| address = server.internal_ip | ||
| port = MEMCACHED_PORT | ||
|
|
||
| logging.info("Trying to connect to memcached at %s:%s" % (address, port)) |
There was a problem hiding this comment.
for logging, you can do logging.info("Trying to connect to memcached at %s:%s" , address, port)
| @@ -0,0 +1,121 @@ | |||
| # Copyright 2014 PerfKitBenchmarker Authors. All rights reserved. | |||
| vm_groups: | ||
| servers: | ||
| vm_spec: *default_single_core | ||
| disk_spec: *default_500_gb |
There was a problem hiding this comment.
does memcached need a disk?
| def StopMemcached(server): | ||
| out, _ = server.RemoteCommand( | ||
| '(echo -e "quit\n" ; sleep 1)| netcat %s %s' % | ||
| (server.internal_ip, memcached_server.MEMCACHED_PORT)) |
There was a problem hiding this comment.
should be part of memcached package?
|
@yuyantingzero thanks for the review. Please take another look |
|
|
||
| FLAGS = flags.FLAGS | ||
|
|
||
| LATEST_URL = 'http://memcached.org/files/memcached-1.4.33.tar.gz' |
There was a problem hiding this comment.
Naming: It is not latest anymore
There was a problem hiding this comment.
Unrelated question to the purpose of this PR: What do you think of refactoring this URL and similar other constants related to software versions in other benchmarks to a YAML file under configs/? I can open an issue to discuss it.
There was a problem hiding this comment.
@meteorfox Sounds good to me
| vm_util.RunThreaded(lambda f: f(), memcached_install_fns + ycsb_install_fns) | ||
| benchmark_spec.executor = ycsb.YCSBExecutor( | ||
| 'memcached', | ||
| **{'memcached.hosts': memcached_vms[0].internal_ip}) |
There was a problem hiding this comment.
How many memcached servers?
From the code, seems like there is no traffic between memcached servers. And this benchmark only use first memcached_vms as ycsb target.
| vm_groups: | ||
| servers: | ||
| vm_spec: *default_single_core | ||
| vm_count: null |
There was a problem hiding this comment.
See comments below, how many server is used
…benchmark server vm count
|
@yuyantingzero could you take another look? |
| config['vm_groups']['clients']['vm_count'] = FLAGS.ycsb_client_vms | ||
|
|
||
| if FLAGS['ycsb_server_vms'].present: | ||
| config['vm_groups']['servers']['vm_count'] = FLAGS.ycsb_server_vms |
There was a problem hiding this comment.
Currently other self-managed ycsb benchmarks use --num_vms as ycsb server vms.
I like --ycsb_server_vms flag, but maybe support it in next pull request for all ycsb benchmarks.
There was a problem hiding this comment.
Alright I'll use --num_vms for this PR
| vm_spec: *default_single_core | ||
| """ | ||
|
|
||
|
|
There was a problem hiding this comment.
Maybe expose some configs here: https://github.com/brianfrankcooper/YCSB/blob/master/memcached/conf/memcached.properties
There was a problem hiding this comment.
I'll add that stuff in a followup PR. I have some more code that adds managed backends to this, and I want to provide configuration options that are equivalent across all providers.
Basically the same as
aerospike_ycsbbenchmark, except is backed by memcached instead.