Adding tests for dynamicUrlToDependency

.eslintrc

@@ -1,10 +1,17 @@
 {
-  "extends": "xo",
+  "extends": "./node_modules/eslint-config-xo/index.js",
   "rules": {
     "default-case": 0,
     "indent": [2, 2, {"SwitchCase": 1}],
     "no-console": 0,
     "no-inline-comments": 0,
-    "space-before-function-paren": [2, "never"]
+    "space-before-function-paren": [2, "never"],
+    "func-style": 0,
+
+		"no-empty-class": 0,
+    "no-extra-strict": 0,
+    "no-reserved-keys": 0,
+    "no-space-before-semi": 0,
+    "no-wrap-func": 0
   }
 }

demo/gulpfile.js

@@ -28,8 +28,8 @@ function runExpress(port, rootDir) {
 
   var server = app.listen(port, function() {
     var host = server.address().address;
-    var port = server.address().port;
-    console.log('Server running at http://%s:%s', host, port);
+    var serverPort = server.address().port;
+    console.log('Server running at http://%s:%s', host, serverPort);
   });
 }
 

gulpfile.js

@@ -14,7 +14,7 @@ gulp.task('generate-demo-service-worker', function(callback) {
 });
 
 gulp.task('lint', ['generate-demo-service-worker'], function() {
-  return gulp.src(['{lib,test,demo}/**/*.js', '*.js'])
+  return gulp.src(['{lib,demo}/**/*.js', '*.js'])
     .pipe($.eslint())
     .pipe($.eslint.format())
     .pipe($.eslint.failOnError());
@@ -25,7 +25,8 @@ gulp.task('test', function() {
     .pipe($.mocha())
     .on('error', function(error) {
       console.error(error);
-      process.exit(1);
+      // process.exit(1);
+      throw error;
     });
 });
 

lib/sw-precache.js

@@ -67,9 +67,9 @@ function escapeRegExp(string) {
   return string.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
 }
 
-function generate(params, callback) {
+function generate(inputParams, callback) {
   return new Promise(function(resolve, reject) {
-    params = defaults(params || {}, {
+    var params = defaults(inputParams || {}, {
       cacheId: '',
       directoryIndex: 'index.html',
       dynamicUrlToDependencies: {},

package.json

@@ -21,8 +21,8 @@
   },
   "devDependencies": {
     "del": "^1.2.0",
-    "eslint": "^1.9.0",
-    "eslint-config-xo": "^0.6.0",
+    "eslint": "^1.10.2",
+    "eslint-config-xo": "^0.8.0",
     "express": "^4.12.4",
     "gh-pages": "^0.3.1",
     "grunt": "^0.4.5",

test/data/templates/a.handlebars

@@ -0,0 +1 @@
+<h1>Template: A</h1>

test/data/templates/b.handlebars

@@ -0,0 +1 @@
+<h1>Template: B</h1>

test/test.js

@@ -388,3 +388,89 @@ describe('addDirectoryIndex', function() {
     done();
   });
 });
+
+describe('dynamicUrlToDependencies', function() {
+  var SW_FILE = 'test/output/dynamicUrlToDependencies_sw.js';
+
+  it('should not throw an error when using dynamicUrlToDependencies', function(done) {
+    var config = {
+      logger: NOOP,
+      dynamicUrlToDependencies: {
+        '/fake': [
+          'test/data/templates/a.handlebars'
+        ]
+      }
+    };
+
+    write(SW_FILE, config, function(error) {
+      assert.ifError(error);
+      fs.stat(SW_FILE, function(error, stats) {
+        assert.ifError(error);
+        assert(stats.isFile(), 'file exists');
+        assert(stats.size > 0, 'file contains data');
+        done();
+      });
+    });
+  });
+
+  it('should not throw an error for multiple files in a dynamicUrlToDependency', function(done) {
+    var config = {
+      logger: NOOP,
+      dynamicUrlToDependencies: {
+        '/fake': [
+          'test/data/templates/a.handlebars',
+          'test/data/templates/b.handlebars'
+        ]
+      }
+    };
+
+    write(SW_FILE, config, function(error) {
+      assert.ifError(error);
+      fs.stat(SW_FILE, function(error, stats) {
+        assert.ifError(error);
+        assert(stats.isFile(), 'file exists');
+        assert(stats.size > 0, 'file contains data');
+        done();
+      });
+    });
+  });
+
+  it('should throw an error for an invalid file in a dynamicUrlToDependency', function(done) {
+    var config = {
+      logger: NOOP,
+      dynamicUrlToDependencies: {
+        '/fake': [
+          'test/data/templates/non-existant.handlebars'
+        ]
+      }
+    };
+
+    write(SW_FILE, config, function(error) {
+      assert(error);
+      done();
+    });
+  });
+
+  it('should throw an error for one non existant file in an array in dynamicUrlToDependency', function(done) {
+    var config = {
+      logger: NOOP,
+      dynamicUrlToDependencies: {
+        '/fake': [
+          'test/data/templates/a.handlebars',
+          'test/data/templates/b.handlebars',
+          'test/data/templates/non-existant.handlebars'
+        ]
+      }
+    };
+
+    write(SW_FILE, config, function(error) {
+      assert(error);
+      done();
+    });
+  });
+
+  after(function() {
+    fs.unlinkSync(SW_FILE);
+    fs.rmdirSync(path.dirname(SW_FILE));
+  });
+});