Skip to content
This repository has been archived by the owner on Jan 23, 2021. It is now read-only.

Only run gulp build:dist if we're in production #189

Merged
merged 1 commit into from
Sep 21, 2016

Conversation

jeffposnick
Copy link
Contributor

R: @petele

This should fix the issue @petele was seeing when running npm install from within the app-shell-demo/ directory in a freshly cloned copy of the code.

@jeffposnick jeffposnick merged commit 4ed429d into master Sep 21, 2016
@jeffposnick jeffposnick deleted the postinstall-production-check branch September 21, 2016 18:16
@echeese
Copy link

echeese commented Sep 21, 2016

This is causing npm postinstall to fail on Windows.

@jeffposnick
Copy link
Contributor Author

Sorry about that, @echeese. I've reverted and will come up with an alternative approach.

Just to confirm, this didn't impact usage of the core sw-precache library, right? It's just when you tried to test out app-shell-demo locally?

@echeese
Copy link

echeese commented Sep 22, 2016

It's okay, it seems like it works fine, the postinstall just fails. However, everything else seems to work fine.

@jeffposnick
Copy link
Contributor Author

Right, but just to clarify, you were specifically running an npm install for a local copy of the app-shell-demo/ project when you encountered this, right?

I want to confirm that this isn't impacting all Windows users who just do a general npm install sw-precache (and don't have a Windows machine handy to test at the moment...).

@echeese
Copy link

echeese commented Sep 22, 2016

sw-precache installed fine, the error only happened when I explicitly changed to the app-shell-demo subdirectory and ran npm install.

@jeffposnick
Copy link
Contributor Author

Thanks for confirming!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants