Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hash part of URL from request URL and client URL #17

Merged
merged 1 commit into from
Aug 21, 2020
+8 −2
Merged

Remove hash part of URL from request URL and client URL #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions packages/appcache-polyfill-sw/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,15 +207,21 @@ async function appCacheBehaviorForEvent(event: FetchEvent) {
return fetch(event.request);
}

const requestUrl = new URL(event.request.url);
const originalUrl = event.request.url;
const urlWithoutHash = originalUrl.split('#')[0];

const requestUrl = new URL(urlWithoutHash);

// Appcache rules only apply to GETs & same-scheme requests.
if (event.request.method !== 'GET' ||
requestUrl.protocol !== location.protocol) {
return fetch(event.request);
}

const clientUrl = await getClientUrlForEvent(event);
const originalClientUrl = await getClientUrlForEvent(event);
const clientUrlWithoutHash = originalClientUrl.split('#')[0];

const clientUrl = clientUrlWithoutHash;
const pageURLToManifestURL: PageURLToManifestURL =
await storage.get('PageURLToManifestURL');
const manifestUrl = pageURLToManifestURL[clientUrl];
Expand Down