Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[infra] allow react 17 as a peer dependency #62

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

jdanil
Copy link
Contributor

@jdanil jdanil commented Dec 8, 2020

Bumping the react peer dependency for use with react 17.
Tests are all passing. Don't believe anything changed with useEffect or useState in react 17.

@google-cla
Copy link

google-cla bot commented Dec 8, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@jdanil
Copy link
Contributor Author

jdanil commented Mar 28, 2021

@googlebot I signed it!

@jdanil
Copy link
Contributor Author

jdanil commented Mar 28, 2021

@addyosmani, sorry for the delay. Just signed the CLA when you have time to check this out.

@chicio
Copy link

chicio commented Oct 15, 2021

Can we merge this improvement?

@chicio
Copy link

chicio commented Feb 24, 2022

Someone can help/merge?

@addyosmani addyosmani merged commit baad292 into GoogleChromeLabs:master Feb 24, 2022
@addyosmani
Copy link
Collaborator

Thank you for the friendly ping here!

@chicio
Copy link

chicio commented Feb 24, 2022

Thank you @addyosmani!!! 🙏

@addyosmani
Copy link
Collaborator

addyosmani commented Feb 24, 2022

Sure! Are there any other PRs you would like to see landed before a release goes out? We're holding steady at ~5K downloads a week (awesome) but I do want to make sure folks aren't feeling blocked if there are important fixes or additions in the PR queue worth taking a look at.

@chicio
Copy link

chicio commented Feb 24, 2022

At the moment this was the most important PR for me because in this way I can avoid to use the legacy peer deps flag with npm. Thank you again for your support 🙏

@danieleloscozzese
Copy link

This would be a valuable release in order to resolve the --legacy-peer-deps flag when installing with npm, as mentioned by @chicio. The upgrades in the PR queue look like in-range upgrades so far, I myself don't have any great request for another merge. A v0.0.9 including this peer dependency range expansion would be useful as-is.

@adamhouten
Copy link

Apologies for commenting on a year old PR, but did this change ever end up into a published version of the package? I've checked the npm page, and the latest version still seems to be v0.0.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants