-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[infra] allow react 17 as a peer dependency #62
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
@addyosmani, sorry for the delay. Just signed the CLA when you have time to check this out. |
Can we merge this improvement? |
Someone can help/merge? |
Thank you for the friendly ping here! |
Thank you @addyosmani!!! 🙏 |
Sure! Are there any other PRs you would like to see landed before a release goes out? We're holding steady at ~5K downloads a week (awesome) but I do want to make sure folks aren't feeling blocked if there are important fixes or additions in the PR queue worth taking a look at. |
At the moment this was the most important PR for me because in this way I can avoid to use the legacy peer deps flag with npm. Thank you again for your support 🙏 |
This would be a valuable release in order to resolve the |
Apologies for commenting on a year old PR, but did this change ever end up into a published version of the package? I've checked the npm page, and the latest version still seems to be |
Bumping the react peer dependency for use with react 17.
Tests are all passing. Don't believe anything changed with
useEffect
oruseState
in react 17.