Skip to content
This repository has been archived by the owner on Jan 21, 2021. It is now read-only.

compatible with html-webpack-plugin v4 hooks #80

Closed
wants to merge 1 commit into from

Conversation

arizonatribe
Copy link

Addresses this issue starting to pop up for those using the newer version (v4 beta) of Html Webpack Plugin`.

Preload Webpack Plugin depends on some hooks that are no longer placed onto the Webpack compilation object (with the "htmlWebpack" prefix), so it seems an explicit peer dependency might need to be adopted so that its new static method getHooks() can be used.

Not sure if adopting a peer dependency is the best solution or not; let me know what you think.

Thanks!

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants