This repository has been archived by the owner on Jan 21, 2021. It is now read-only.
compatible with html-webpack-plugin v4 hooks #80
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses this issue starting to pop up for those using the newer version (v4 beta) of Html Webpack Plugin`.
Preload Webpack Plugin depends on some hooks that are no longer placed onto the Webpack compilation object (with the "htmlWebpack" prefix), so it seems an explicit peer dependency might need to be adopted so that its new static method
getHooks()
can be used.Not sure if adopting a peer dependency is the best solution or not; let me know what you think.
Thanks!