This repository has been archived by the owner on Oct 25, 2024. It is now read-only.
fix: add missing peer dependency html-webpack-plugin
#91
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
critters-webpack-plugin
tries to requirehtml-webpack-plugin
(critters/packages/critters-webpack-plugin/src/index.js
Lines 71 to 75 in 5e32531
https://yarnpkg.com/advanced/rulebook/#packages-should-only-ever-require-what-they-formally-list-in-their-dependencies
Ref preactjs/preact-cli#1608 (comment) (cc @rschristian)
How did you fix it?
Based on how
critters-webpack-plugin
is trying to usehtml-webpack-plugin
I added it as an optional peer dependency.