Adds a generator_app metatag to AndroidManifest.xml
#90
Conversation
src/cli/cmds/init.ts
Outdated
| @@ -25,6 +25,7 @@ import {TwaGenerator} from '../../lib/TwaGenerator'; | |||
| import {TwaManifest} from '../../lib/TwaManifest'; | |||
| import {validateColor, validatePassword, validateUrl, notEmpty} from '../inputHelpers'; | |||
| import {ParsedArgs} from 'minimist'; | |||
| import {APP_NAME} from '../consts'; | |||
There was a problem hiding this comment.
Could you please renaming this file to "constants"?
| @@ -120,6 +120,7 @@ export class TwaManifest { | |||
| signingKey: SigningKeyInfo; | |||
| appVersion: string; | |||
| shortcuts: string; | |||
| generatorApp: string; | |||
There was a problem hiding this comment.
On the subject of constants, can any of these members be constant?
There was a problem hiding this comment.
Not the members. But moving sone of the "magic values" throughout the code to consts sound like a good idea.
There was a problem hiding this comment.
Moved the default values to consts. Not sure what the best practice for JSON field names is.
src/cli/consts.ts
Outdated
| * limitations under the License. | ||
| */ | ||
|
|
||
| export const APP_NAME = 'llama-pack-cli'; |
There was a problem hiding this comment.
What are our current thoughts about including the llama-pack version as well?
There was a problem hiding this comment.
I think we want to add it at some point. Not sure what's the best approach right now though (Do we want the llama-pack version, the template version or most likely both?). So punting this bit until we have more clarity
- Renames `consts.ts` to `constants.ts` - Moves magic values to consts in `TwaManifest.js`
@JudahGabriel FYI