Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Android SDK version 35, with many consequential updates #862

Merged
merged 3 commits into from
Jul 17, 2024

Commits on Jul 10, 2024

  1. Support Android SDK version 35, with many consequential updates

    Fix npm install - dependency changes meant that bubblewrap
    wouldn't compile due to dependencies not supporting previous
    TypeScript version. To address this, updated TypeScript to 5.5.3.
    
    Updating TypeScript necessitates updating inquirer. Inquirer has
    been re-written in version 10, and version 9 is EPM only, while
    other dependencies need it to be CommonJS. So inquirer was updated
    to 8.2.6 for now - the latest CommonJS supporting version with the
    legacy API. As part of this change, esModuleInterop has been turned
    on, and the module import style has been made consistent, avoiding
    type errors.
    
    A few other minor changes (particularly to caught errors) were needed
    for TS5.5.3 compat.
    
    Next, the main aim of this change updates the targetSdkVersion and
    compileSdkVersion in app/build.gradle in the template. However, this
    also requires adding the namespace (set to the package ID) to the
    template.
    
    Updating the compileSdkVersion requires bumping the Android Gradle
    plugin to the latest 8.5.0.
    
    This change makes it no longer compatible with JDK 11, so this
    requires another extensive change - updating to OpenJDK 17. This
    has a number of consequential documentation and string updates,
    including moving the installer to use Eclipse Temurin instead of
    AdoptOpenJDK.
    
    Finally, updating JDK requires updating the Gradle wrapper. The
    outputs are from running `gradle wrapper --gradle-version 8.8`.
    A1kmm committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    eb5f3a9 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Configuration menu
    Copy the full SHA
    39d5972 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2334ccd View commit details
    Browse the repository at this point in the history