Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escaping user input to key tool #83

Merged
merged 1 commit into from
Jan 23, 2020

Conversation

JudahGabriel
Copy link
Contributor

Fixes the issue where e.g. the key password contains a hyphen.

Fixes the issue where e.g. the key password contains a hyphen.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@JudahGabriel
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Member

@andreban andreban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank You!!

@andreban andreban merged commit 76ae224 into GoogleChromeLabs:master Jan 23, 2020
`-keypass ${keyOptions.keypassword}`,
`-keystore ${keyOptions.path}`,
`-storepass ${keyOptions.password}`,
`-alias \"${keyOptions.alias}\"`,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need the backslashes here since we're using a template string (eg, there's just " instead of \" on line 67).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PS: Even though it's not needed, the output is correct with the escapes.

@andreban andreban added the bug Something isn't working label Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants