Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move distributionUrl to the bottom #63

Merged
merged 1 commit into from
Jan 15, 2020
Merged

Move distributionUrl to the bottom #63

merged 1 commit into from
Jan 15, 2020

Conversation

abdonrd
Copy link
Contributor

@abdonrd abdonrd commented Jan 14, 2020

When you create a new Android Project from Android Studio, it on the bottom.
Just to less diffing if you come from an Android Studio project.

@abdonrd
Move distributionUrl to the bottom
8c27b0b 
When you create a new Android Project from Android Studio, it on the bottom
@PEConn PEConn requested a review from andreban January 15, 2020 10:04
@PEConn
Copy link
Collaborator

PEConn commented Jan 15, 2020

Fine by me, Andre thoughts?

andreban
andreban approved these changes Jan 15, 2020
View reviewed changes
Copy link
Member

@andreban andreban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you!

@andreban andreban merged commit 34ee157 into GoogleChromeLabs:master Jan 15, 2020
@abdonrd abdonrd deleted the patch-1 branch January 15, 2020 10:11
@andreban andreban added the enhancement New feature or request label Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreban andreban andreban approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abdonrd @PEConn @andreban