Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uses android-browser-helper #55

Merged
merged 2 commits into from
Jan 8, 2020
Merged

Uses android-browser-helper #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72130db
Uses android-browser-helper
andreban Jan 7, 2020
a8bfeb5
Use the official android-browser-helper Library
andreban Jan 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions template_project/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,13 @@ def twaManifest = [
]

android {
compileSdkVersion 28
compileSdkVersion 29
defaultConfig {
applicationId "<%= packageId %>"
minSdkVersion 16
targetSdkVersion 28
targetSdkVersion 29
versionCode 1
versionName "1.0"
versionName "2.0.0"

// The name for the application on the Android Launcher
resValue "string", "appName", twaManifest.name
Expand Down Expand Up @@ -155,5 +155,5 @@ preBuild.dependsOn(generateShorcutsFile)

dependencies {
implementation fileTree(include: ['*.jar'], dir: 'libs')
implementation 'com.github.GoogleChrome.custom-tabs-client:customtabs:809a55cfa2'
implementation 'com.google.androidbrowserhelper:androidbrowserhelper:1.0.0'
}
6 changes: 3 additions & 3 deletions template_project/app/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
android:name="cros_web_alternative"
android:value="@string/crosLaunchUrl" />

<activity android:name="android.support.customtabs.trusted.LauncherActivity"
<activity android:name="com.google.androidbrowserhelper.trusted.LauncherActivity"
android:label="@string/appName">
<meta-data android:name="android.support.customtabs.trusted.DEFAULT_URL"
android:value="@string/launchUrl" />
Expand Down Expand Up @@ -79,7 +79,7 @@
</activity>

<provider
android:name="android.support.v4.content.FileProvider"
android:name="androidx.core.content.FileProvider"
android:authorities="@string/providerAuthority"
android:grantUriPermissions="true"
android:exported="false">
Expand All @@ -89,7 +89,7 @@
</provider>

<service
android:name="android.support.customtabs.trusted.TrustedWebActivityService"
android:name="com.google.androidbrowserhelper.trusted.DelegationService"
android:enabled="@bool/enableNotification"
android:exported="@bool/enableNotification">

Expand Down
4 changes: 0 additions & 4 deletions template_project/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,6 @@ allprojects {
repositories {
google()
jcenter()
// Jitpack is currently being used to publish beta versions of the TWA Support Library.
// This will change in the future to use the same approach as other Android Support
// Libraries.
maven { url "https://jitpack.io" }
}
}

Expand Down