Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure eslint to lint ts files #42

Merged
merged 3 commits into from
Dec 1, 2019
Merged

Configure eslint to lint ts files #42

merged 3 commits into from
Dec 1, 2019

Conversation

NotWoods
Copy link
Contributor

I think ESLint only checks JS files by default. Adjusts the command to check ts files and adds the typescript parser. @typescript-eslint/eslint-plugin could be added for TS-specific rules.

@PEConn
Copy link
Collaborator

PEConn commented Nov 29, 2019

Thanks for this! Will eslint with the TypeScript plugin do the same as TSLint or are there differences?

@andreban this LGTM, over to you.

@andreban andreban self-requested a review November 29, 2019 11:52
Copy link
Member

@andreban andreban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NotWoods Thanks for this! We should definitely add @typescript-eslint/eslint-plugin. Let me know if you want to add it to this PR, send in another one, or I can pick it up and make the PR.

@NotWoods
Copy link
Contributor Author

I can add the plugin in 🙂

@andreban andreban merged commit e068937 into GoogleChromeLabs:master Dec 1, 2019
@andreban andreban added documentation Improvements or additions to documentation internal and removed documentation Improvements or additions to documentation labels Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants