Implements input validation for the AplicationId #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
andreban
commented
Apr 9, 2020
andreban
commented
- Implements validation and tests
- Improves some error messages on the CLI
- Implements validation and tests - Improves some error messages on the CLI
andreban
force-pushed
the
applicationid-validation
branch
from
9862f8b
to
a40acc2
Compare
- Removes repetitions for notEmpty validations. - Improves validation for keystore passwords. - Adds tests for notEmpty, validateKeyPassword and validatecolor.
PEConn
approved these changes
Apr 15, 2020
| it('returns false for packages with invalid characters', () => { | ||
| expect(util.validatePackageId('com.pwa-directory.appspot.com')).toBeFalse(); | ||
| expect(util.validatePackageId('[email protected]')).toBeFalse(); | ||
| expect(util.validatePackageId('com.pwa*directory.appspot.com')).toBeFalse(); |
There was a problem hiding this comment.
Maybe it's worth adding an example with some weird unicode character (maybe a unicode character that looks like a full stop but isn't).
| it('packages starting with non-letters return false', () => { | ||
| expect(util.validatePackageId('com.1char.twa')).toBeFalse(); | ||
| expect(util.validatePackageId('1com.char.twa')).toBeFalse(); | ||
| expect(util.validatePackageId('com.char.1twa')).toBeFalse(); |
There was a problem hiding this comment.
One that starts with an underscore?
There was a problem hiding this comment.
\u2024 (․) should do it.
packages/cli/src/lib/cmds/init.ts
Outdated
| }, { | ||
| name: 'keyAlias', | ||
| type: 'input', | ||
| message: 'Key name:', | ||
| default: twaManifest.signingKey.alias, | ||
| validate: notEmpty, | ||
| validate: async (input): Promise<boolean> => notEmpty(input, 'Key alias cannot be empty'), |
There was a problem hiding this comment.
Could you just pass the name to notEmpty and have notEmpty take care of the "cannot be empty" part? (As it is, for half of these you say "cannot be empty" and the other half you have "can't be empty".
| await expectAsync(inputHelpers.validateKeyPassword(' ')).toBeRejectedWithError(); | ||
| }); | ||
|
|
||
| it('throws Error for empty string', async () => { |
| await expectAsync(inputHelpers.validateKeyPassword('abcde ')).toBeRejectedWithError(); | ||
| }); | ||
|
|
||
| it('throws Error for empty string', async () => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.