Fix #759 Drop support for Node 12 (#763)

* Fix #759 Drop support for Node 12 * Update ReadMe * Update * Update * Update
GoogleChromeLabs · Feb 20, 2023 · 88b2cb0 · 88b2cb0
1 parent c44bbed
commit 88b2cb0
Show file tree

Hide file tree

Showing 15 changed files with 28 additions and 6 deletions.
diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml
@@ -9,7 +9,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [12.x, 14.x, 16.x]
+        node-version: [14.x, 16.x, 18.x]
 
     steps:
     - uses: actions/checkout@v2

diff --git a/.npmrc b/.npmrc
@@ -0,0 +1 @@
+engine-strict=true
diff --git a/README.md b/README.md
@@ -22,7 +22,7 @@ projects for Android Applications that launch Progressive Web App (PWA) using
 [Trusted Web Activity (TWA)](https://developer.chrome.com/docs/android/trusted-web-activity/).
 
 ## Requirements
-- [Node.js](https://nodejs.org/en/) 12.0 or above
+- [Node.js](https://nodejs.org/en/) 14.15.0 or above
 
 ## Getting Started
 - To get started with building an application using Bubblewrap, check the [Trusted Web Activity

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -3,6 +3,9 @@
   "private": true,
   "version": "0.4.3",
   "description": "Generate TWA projects from a Web Manifest",
+  "engines": {
+    "node": ">=14.15.0"
+  },
   "scripts": {
     "build": "lerna run build",
     "lint": "lerna run lint",

diff --git a/packages/cli/.npmrc b/packages/cli/.npmrc
@@ -0,0 +1 @@
+engine-strict=true
diff --git a/packages/cli/README.md b/packages/cli/README.md
@@ -22,7 +22,7 @@ a Project for an Android application that launches an existing Progressive Web A
 [Trusted Web Activity (TWA)](https://developer.chrome.com/docs/android/trusted-web-activity/).
 
 ## Requirements
-- [Node.js](https://nodejs.org/en/) 12.0 or above
+- [Node.js](https://nodejs.org/en/) 14.15.0 or above
 
 ## Setting up the Environment
 

diff --git a/packages/cli/package.json b/packages/cli/package.json
@@ -2,6 +2,9 @@
   "name": "@bubblewrap/cli",
   "version": "1.19.1",
   "description": "CLI tool to Generate TWA projects from a Web Manifest",
+  "engines": {
+    "node": ">=14.15.0"
+  },
   "bin": {
     "bubblewrap": "bin/bubblewrap.js"
   },

diff --git a/packages/cli/src/lib/Cli.ts b/packages/cli/src/lib/Cli.ts
@@ -36,9 +36,9 @@ import {fetchUtils} from '@bubblewrap/core';
 export class Cli {
   async run(args: string[]): Promise<boolean> {
     console.log(BUBBLEWRAP_LOGO);
-    if (major(process.versions.node) < 12) {
+    if (major(process.versions.node) < 14) {
       throw new Error(`Current Node.js version is ${process.versions.node}.` +
-          ' Node.js version 12 or above is required to run bubblewrap.');
+          ' Node.js version 14 or above is required to run Bubblewrap.');
     }
     const parsedArgs = minimist(args);
     if (parsedArgs.fetchEngine &&

diff --git a/packages/core/.npmrc b/packages/core/.npmrc
@@ -0,0 +1 @@
+engine-strict=true
diff --git a/packages/core/README.md b/packages/core/README.md
@@ -22,7 +22,7 @@ application that launches an existing Progressive Web App (PWA) using a
 [Trusted Web Activity (TWA)](https://developer.chrome.com/docs/android/trusted-web-activity/).
 
 ## Requirements
-- [Node.js](https://nodejs.org/en/) 12.0 or above
+- [Node.js](https://nodejs.org/en/) 14.15.0 or above
 
 ## Setting up the Environment
 

diff --git a/packages/core/package.json b/packages/core/package.json
@@ -2,6 +2,9 @@
   "name": "@bubblewrap/core",
   "version": "1.19.1",
   "description": "Core Library to generate, build and sign TWA projects",
+  "engines": {
+    "node": ">=14.15.0"
+  },
   "scripts": {
     "build": "tsc",
     "clean": "del dist",

diff --git a/packages/validator/.npmrc b/packages/validator/.npmrc
@@ -0,0 +1 @@
+engine-strict=true
diff --git a/packages/validator/README.md b/packages/validator/README.md
@@ -22,3 +22,6 @@ App(PWA) used inside it matchs the [minimum quality criteria][2].
 
 [1]: https://developer.chrome.com/docs/android/trusted-web-activity/
 [2]: https://web.dev/using-a-pwa-in-your-android-app/#quality-criteria
+
+## Requirements
+- [Node.js](https://nodejs.org/en/) 14.15.0 or above
diff --git a/packages/validator/package.json b/packages/validator/package.json
@@ -2,6 +2,9 @@
   "name": "@bubblewrap/validator",
   "version": "1.18.1",
   "description": "Validate if an app using Trusted Web Activity fulfills the quality criteria",
+  "engines": {
+    "node": ">=14.15.0"
+  },
   "scripts": {
     "build": "tsc",
     "clean": "del dist",