Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds exported types to moduleResolution:node16 #137

Merged

Conversation

dmihalcik-virtru
Copy link
Contributor

This will let users get type information when compiling ESM projects with node module settings in later versions of tsc and node 18+

This will let users get type information when compiling ESM projects with node module settings in later versions of tsc and node 18+
@google-cla
Copy link

google-cla bot commented Jan 12, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@dmihalcik-virtru
Copy link
Contributor Author

Notably, without this line I'll get the following error when trying to build my project (node 18, tsconfig with module: CommonJS, moduleResolution: node16, package.json with type: module), so maybe not a common configuration but what I'm doing :-0

image

Copy link
Member

@tomayac tomayac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomayac tomayac merged commit fdc80eb into GoogleChromeLabs:main Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants