Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

[Add Manifest article] Add translations #6520

Closed
wants to merge 1 commit into from
Closed

Conversation

tomayac
Copy link
Member

@tomayac tomayac commented Oct 25, 2021

Changes proposed in this pull request:

  • Add translations

We're still awaiting the final design, this is mostly a placeholder PR until the design is final.

@netlify
Copy link

netlify bot commented Oct 25, 2021

✔️ Deploy Preview for web-dev-staging ready!

🔨 Explore the source changes: 138a038

🔍 Inspect the deploy log: https://app.netlify.com/sites/web-dev-staging/deploys/617654de084e560007ce5ad1

😎 Browse the preview: https://deploy-preview-6520--web-dev-staging.netlify.app

@google-cla google-cla bot added the cla: yes Contributor has signed the CLA label Oct 25, 2021
@tomayac tomayac requested a review from jpmedley October 25, 2021 06:55
@chrome-devrel-review-bot
Copy link
Collaborator

Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated.

Requested changes

If there are any common problems with the content files you created or modified, they will be listed here.

src/site/content/en/progressive-web-apps/add-manifest/index.md

  • Please change your usage of the following words:
    • Do not use master. Affected lines: 458

1 similar comment
@chrome-devrel-review-bot
Copy link
Collaborator

Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated.

Requested changes

If there are any common problems with the content files you created or modified, they will be listed here.

src/site/content/en/progressive-web-apps/add-manifest/index.md

  • Please change your usage of the following words:
    • Do not use master. Affected lines: 458

@tomayac tomayac added the $-presubmit Add label to run presubmit tests. label Oct 25, 2021
@github-actions github-actions bot removed the $-presubmit Add label to run presubmit tests. label Oct 25, 2021
@tomayac tomayac added the DO NOT MERGE Actively working on but experimental label Oct 25, 2021
@tomayac tomayac marked this pull request as draft October 25, 2021 08:01
@stale
Copy link

stale bot commented Jan 25, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. To prevent this from happening, leave a comment.

@stale stale bot added the stale label Jan 25, 2022
@tomayac
Copy link
Member Author

tomayac commented Jan 25, 2022

Still waiting for the spec.

@stale stale bot removed the stale label Jan 25, 2022
@tomayac tomayac added the accepted **Should be used by Eng team only**: Use this to tell the stalebot to keep a bug or PR open. label Jan 25, 2022
@rachelandrew
Copy link
Collaborator

@tomayac is this still ongoing?

@tomayac
Copy link
Member Author

tomayac commented Jul 12, 2022

It is, but we're still waiting for w3c/manifest#676 to get closed.

@tomayac
Copy link
Member Author

tomayac commented Aug 16, 2023

After being started in 2021, this feature still hasn't landed and is pending more discussion, so it's fair to close this PR. Please keep the branch around, so we can get back to the proposed changes if need be.

@rachelandrew
Copy link
Collaborator

@tomayac as you know we're migrating, so you'll need to take a copy of the content.

@tomayac
Copy link
Member Author

tomayac commented Aug 16, 2023

Will the repos be deleted? I thought we'd archive them?!

@rachelandrew
Copy link
Collaborator

Not really sure what the plan is, I need to check what we are expected to do (I'm sure there is a process) but if it were me, and something was important to me to keep, I'd make sure I had a copy of it just in case.

@tomayac
Copy link
Member Author

tomayac commented Aug 16, 2023

Understood. I'll dump the article contents in a doc then.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted **Should be used by Eng team only**: Use this to tell the stalebot to keep a bug or PR open. cla: yes Contributor has signed the CLA DO NOT MERGE Actively working on but experimental
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants