Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

Correct description of COOP unsafe-none #3185

Merged
merged 1 commit into from
Jun 10, 2020

Conversation

jugglinmike
Copy link
Contributor

Contrary to the current explanation, when an opener specifies a COOP of
same-origin-allow-popups and the opened resource specifies
unsafe-none, then the two documents will share the same browsing
context group.

This is supported by the explanation of same-origin-allow-popups which
precedes this section:

A top-level document with same-origin-allow-popups retains
references to > any of its popups which either don't set COOP or which
opt out of isolation > by setting a COOP of unsafe-none.

It is also supported by the proposed specification text [1] which reads:

To check if a response requires a browsing context group switch ,
given a browsing context browsingContext , an origin responseOrigin
and a cross-origin opener policy responseCOOP , run the followign
steps:

[...]

  1. If all of the following are true:

    • isInitialAboutBlank
    • activeDocumentCOOP is " same-origin-allow-popups ".
    • responseCOOP is " unsafe-none ".

    then return false.

Update the explanation to only include the relevant condition (that is:
a COOP of same-origin).

[1] whatwg/html#5334

Fixes #SOME_ISSUE_NUMBER

Changes proposed in this pull request:

Contrary to the current explanation, when an opener specifies a COOP of
`same-origin-allow-popups` and the opened resource specifies
`unsafe-none`, then the two documents *will* share the same browsing
context group.

This is supported by the explanation of `same-origin-allow-popups` which
precedes this section:

> A top-level document with `same-origin-allow-popups` retains
references to > any of its popups which either don't set COOP or which
opt out of isolation > by setting a COOP of `unsafe-none`.

It is also supported by the proposed specification text [1] which reads:

> To check if a response requires a browsing context group switch ,
> given a browsing context browsingContext , an origin responseOrigin
> and a cross-origin opener policy responseCOOP , run the followign
> steps:
>
> [...]
>
> 6. If all of the following are true:
>
>    - isInitialAboutBlank
>    - activeDocumentCOOP is " same-origin-allow-popups ".
>    - responseCOOP is " unsafe-none ".
>
>    then return false.

Update the explanation to only include the relevant condition (that is:
a COOP of `same-origin`).

[1] whatwg/html#5334
@netlify
Copy link

netlify bot commented Jun 10, 2020

Deploy preview for web-dev-staging ready!

Built with commit c9106e5

https://deploy-preview-3185--web-dev-staging.netlify.app

@jugglinmike
Copy link
Contributor Author

cc @agektmr and @domenic

@kaycebasques kaycebasques merged commit c3b4ee0 into GoogleChrome:master Jun 10, 2020
@kaycebasques kaycebasques added content update for issues that do not require new content (only for updates to existing content) privacy/security labels Jun 10, 2020
@kaycebasques kaycebasques added this to the 2020 Jun 30 milestone Jun 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
content update for issues that do not require new content (only for updates to existing content)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants