-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save a reference to the LCP and CLS elements in case they are removed from the DOM #562
base: v5
Are you sure you want to change the base?
Conversation
Test here: https://disappearing-cwv-node.glitch.me/index.html Maybe we should add this to the test suite? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should add this to the test suite?
Yes, I think we want a test for this behavior. It should be possible to test.
Added tests for LCP, CLS and even the INP scenario added in #477 |
Can you add the same logic for metric -> lcpEntry -> element? |
I've added it as a new |
Co-authored-by: Philip Walton <[email protected]>
Fixes #561