Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test flakiness #507

Merged
merged 28 commits into from
Aug 4, 2024
Merged

Improve test flakiness #507

merged 28 commits into from
Aug 4, 2024

Conversation

tunetheweb
Copy link
Member

@tunetheweb tunetheweb commented Aug 1, 2024

Makes the following improvements:

@tunetheweb tunetheweb changed the title Remove firefox workarounds for test flakiness Improve test flakiness Aug 1, 2024
test/e2e/onLCP-test.js Outdated Show resolved Hide resolved
test/e2e/onFCP-test.js Outdated Show resolved Hide resolved
@philipwalton
Copy link
Member

I reverted the checks that would skip some tests in browsers that don't support prerender. I don't think the prerender-stubbing code was the cause of the flakiness, I think it was mainly the issue we discovered with the navigateTo() method.

IMO it only makes sense to skip the check if we're actually triggering a prerender load somehow. If we're stubbing it then I think running the tests in all browsers is still useful to check that out assumptions of how things work are interoperable.

@philipwalton
Copy link
Member

I've run the tests three times in a row now and they've all passed each time.

@tunetheweb tunetheweb merged commit 5b91b76 into main Aug 4, 2024
8 checks passed
@tunetheweb tunetheweb deleted the remove-firefox-test-workaround branch August 4, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants