Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(plugins): update recipe, suggest NODE_ENV=.. hack #9997

Merged
merged 1 commit into from
Nov 20, 2019
Merged

docs(plugins): update recipe, suggest NODE_ENV=.. hack #9997

merged 1 commit into from
Nov 20, 2019

Conversation

connorjclark
Copy link
Collaborator

@connorjclark connorjclark commented Nov 20, 2019 •
edited
Loading

suggest the hack I came up with in treosh/lighthouse-ci-action#16

(edit: typo; meant to be NODE_PATH=, was fixed in #10028 )

paulirish
paulirish approved these changes Nov 20, 2019
View reviewed changes
Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome. thanks.

We still have some polish to do to avoid the NODE_ENV hack but I want to make sure any plugin devs aren't struggling in the meantime

@paulirish paulirish mentioned this pull request Nov 20, 2019
Closed
@paulirish paulirish merged commit 508abc5 into master Nov 20, 2019
@paulirish paulirish deleted the plugins-dev-local branch November 20, 2019 19:47
@paulirish paulirish mentioned this pull request Nov 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulirish paulirish paulirish approved these changes

Assignees
No one assigned
Labels
cla: yes land-when-ci-is-green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@connorjclark @paulirish @googlebot